Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS partitions support for saml2aws console #557

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

AWS partitions support for saml2aws console #557

wants to merge 1 commit into from

Conversation

duckfez
Copy link
Contributor

@duckfez duckfez commented Sep 13, 2020

Fixes #533.

Adds support for saml2aws console to use region= in config file
as a hint for which partition to open the console in.

@duanewaddleAFS
Fixes Versent#533. Adds support for saml2aws console to
f6abda2 
use region= in config file as hint for where to open
the console at.
@duckfez
Copy link
Contributor Author

duckfez commented Sep 13, 2020

I am a little concerned about littering the codebase with special cases for GovCloud and AWS China. But, I don't have the experience with the codebase (or golang itself tbh) to attempt a more comprehensive refactor.

mapkon
mapkon suggested changes Apr 2, 2023
View reviewed changes
Copy link
Contributor

@mapkon mapkon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@duckfez Are you still interested in getting this merged? If yes, please fix the conflicts and check if the code coverage is fine. If not, we can close the PR

@gliptak
Copy link
Contributor

gliptak commented Apr 3, 2023 •
edited
Loading

Okta provider already has special cases

saml2aws/pkg/provider/okta/okta.go

Lines 652 to 654 in 1c3449a

urls = []string{"form[action=\"https://signin.aws.amazon.com/saml\"]",
"form[action=\"https://signin.amazonaws-us-gov.com/saml\"]",
"form[action=\"https://signin.amazonaws.cn/saml\"]",

@duckfez
Copy link
Contributor Author

duckfez commented Apr 3, 2023

I don't mind rebasing this against current main, but I no longer have access to test in GovCloud. The underlying issue #533 has not seen a lot of support for this problem, so maybe it's not worth it? Maybe one of the other interested folks in that issue can help with testing?

@mapkon
Copy link
Contributor

mapkon commented Apr 3, 2023

I don't mind rebasing this against current main, but I no longer have access to test in GovCloud. The underlying issue #533 has not seen a lot of support for this problem, so maybe it's not worth it? Maybe one of the other interested folks in that issue can help with testing?

Thanks for the response! Let us start by rebasing it to main.

@mapkon
Copy link
Contributor

mapkon commented Oct 30, 2023

@duckfez Any traction on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mapkon mapkon mapkon requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

govCloud requires alternate federation URL
4 participants
@duckfez @gliptak @mapkon @duanewaddleAFS